Embed inner exception (ARCH403)

Key dotnet.exception.embed-inner-exception · Severity warning · Category exception

When throwing a new exception inside a catch block, pass the caught exception as the innerException. Otherwise the original stack trace and error context are lost.

Incorrect

try
{
    _repository.Save(order);
}
catch (DbException ex)
{
    throw new OrderSaveException("Could not save order");
}

Correct

try
{
    _repository.Save(order);
}
catch (DbException ex)
{
    throw new OrderSaveException("Could not save order", ex);
}

Fix

Pass the caught exception as the innerException to the new exception’s constructor. If needed, suppress the rule per project/workspace via except/ignore.