Order by before where (ARCH4076)

Key java.performance.orderby-before-where · Severity warning · Category performance

Sorting before filtering also sorts elements that will be discarded. Filter first to shrink the set that has to be sorted.

Incorrect

return orders.stream()
    .sorted(comparing(Order::getDate))
    .filter(Order::isActive)
    .collect(toList());

Correct

return orders.stream()
    .filter(Order::isActive)
    .sorted(comparing(Order::getDate))
    .collect(toList());

Fix

Move the sort after the filter so only the needed elements are sorted.