Magic Number (ARCH4182)

Key java.quality.magic-number · Severity info · Category quality

Numbers hardcoded into expressions hide their meaning and make changes risky. Extract them into well-named constants.

Incorrect

double finalPrice(double base) {
    return base * 1.18 + 25.0;
}

Correct

static final double VAT_RATE = 1.18;
static final double SHIPPING_FEE = 25.0;

double finalPrice(double base) {
    return base * VAT_RATE + SHIPPING_FEE;
}

Fix

Move numeric literals into descriptively named static final constants.