Duplicate Condition Branches (ARCH5190)

Key go.quality.duplicate-branches · Severity warning · Category quality

Branches with identical bodies are usually redundant branching or hide a copy-paste mistake. Merge the branches.

Incorrect

func label(s State) string {
    switch s {
    case Active:
        return "ok"
    case Pending:
        return "ok"
    default:
        return "unknown"
    }
}

Correct

func label(s State) string {
    switch s {
    case Active, Pending:
        return "ok"
    default:
        return "unknown"
    }
}

Fix

Combine branches that produce the same result, or fix the logic that was meant to differ.