Leaked Concurrency Handle (ARCH5085)

Key go.performance.leaked-concurrency-handle · Severity warning · Category performance

Acquiring a Lock without Unlock, or launching a goroutine with no cancellation path, leaks the handle. Guarantee release with defer mu.Unlock().

Incorrect

func (c *Cache) Set(k, v string) {
  c.mu.Lock()
  if c.closed {
    return
  }
  c.data[k] = v
  c.mu.Unlock()
}

Correct

func (c *Cache) Set(k, v string) {
  c.mu.Lock()
  defer c.mu.Unlock()
  if c.closed {
    return
  }
  c.data[k] = v
}

Fix

Release locks with defer mu.Unlock(), and pass a context to goroutines for cancellation.