Throw From Finally (ARCH7155)

Key php.logging.throw-in-finally · Severity error · Category logging

Throwing inside a finally block masks any in-flight exception from the try body, causing the real failure to be lost.

Incorrect

<?php
try {
    $this->process($data);
} finally {
    if (!$this->stream->close()) {
        throw new \RuntimeException('Close failed');
    }
}

Correct

<?php
try {
    $this->process($data);
} finally {
    if (!$this->stream->close()) {
        $this->logger->warning('Stream close failed');
    }
}

Fix

Log the error inside finally instead of throwing; let the original exception propagate.