God Class (ARCH6189)

Key ruby.quality.god-class · Severity warning · Category quality

A class that accumulates too many methods and fields takes on unrelated responsibilities; it has low cohesion and is hard to test and evolve.

Incorrect

class Order
  def calculate_total; end
  def charge_card; end
  def send_email; end
  def generate_pdf; end
  def update_inventory; end
  def post_to_ledger; end
  def notify_shipping; end
end

Correct

class Order
  def calculate_total; end
end

class OrderPayment; def charge; end; end
class OrderNotifier; def send_email; end; end
class Invoice; def generate_pdf; end; end

Fix

Split the class by responsibility into smaller, single-purpose, cohesive classes.