Magic Number (ARCH3182)

Key typescript.quality.magic-number · Severity info · Category quality

Unnamed numeric literals inside expressions hide what they mean, and become hard to maintain when the same value is repeated. They should be extracted into named constants.

Incorrect

function priceWithTax(net: number): number {
  return net * 1.18 + 30;
}

Correct

const VAT_RATE = 0.18;
const SHIPPING_FEE = 30;

function priceWithTax(net: number): number {
  return net * (1 + VAT_RATE) + SHIPPING_FEE;
}

Fix

Extract numeric literals into descriptively named const or enum values.