Log And Rethrow Duplication (ARCH7166)

Key php.logging.log-and-rethrow · Severity warning · Category logging

Logging an exception and rethrowing it in the same handler produces duplicate log entries, since it is logged again higher up the stack.

Incorrect

<?php
try {
    $this->repository->save($entity);
} catch (\PDOException $e) {
    $this->logger->error('Save failed', ['exception' => $e]);
    throw $e;
}

Correct

<?php
try {
    $this->repository->save($entity);
} catch (\PDOException $e) {
    throw new PersistenceException('Save failed', 0, $e);
}

Fix

Either log and swallow, or add context and rethrow - not both.